Skip to content

test_atomic_wait.hpp: remove another timing assumption #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaseyCarter merged 3 commits into from
Aug 14, 2020
Merged

test_atomic_wait.hpp: remove another timing assumption #1193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f92d1d3
remove another timing assumption
AlexGuteniev Aug 14, 2020
5e21173
-newline
AlexGuteniev Aug 14, 2020
b651da7
negate comment
AlexGuteniev Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/std/include/test_atomic_wait.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,14 @@ void test_pad_bits_impl(const std::chrono::steady_clock::duration waiting_durati
c.store(new_value);
c.notify_one();

#ifdef CAN_FAIL_ON_TIMING_ASSUMPTION
std::this_thread::sleep_for(waiting_duration);
assert(trigger);

w1.join();
#else // ^^^ CAN_FAIL_ON_TIMING_ASSUMPTION / !CAN_FAIL_ON_TIMING_ASSUMPTION vvv
w1.join();
assert(trigger);
#endif // ^^^ !CAN_FAIL_ON_TIMING_ASSUMPTION ^^^
}

template <class UnderlyingType>
Expand Down