Limit line length to 120 columns #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach validate.cpp to complain if there are more than 120 code units between line endings in files with particular extensions. Fix the files that it complains about.
StephanTLavavej
requested changes
Aug 20, 2020
StephanTLavavej
approved these changes
Aug 21, 2020
StephanTLavavej
requested changes
Aug 21, 2020
StephanTLavavej
requested changes
Aug 21, 2020
StephanTLavavej
approved these changes
Aug 21, 2020
mnatsuhara
approved these changes
Aug 22, 2020
Member
|
Thanks for enhancing our validation machinery to enforce this! 🤖 This will definitely make reviewing more efficient. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach validate.cpp to complain if there are more than 120 code units between line endings in files with particular extensions. Fix the files that it complains about.