-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Test <coroutine> #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 17 commits into
microsoft:master
from
StephanTLavavej:coroutine_test
Aug 22, 2020
Merged
Test <coroutine> #1215
StephanTLavavej
merged 17 commits into
microsoft:master
from
StephanTLavavej:coroutine_test
Aug 22, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Aug 21, 2020
joemmett
approved these changes
Aug 21, 2020
joemmett
reviewed
Aug 21, 2020
CaseyCarter
approved these changes
Aug 21, 2020
mnatsuhara
approved these changes
Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #40.
This test was contributed by @joemmett. It requires symmetric transfer, implemented by Victor Tong for VS 2019 16.8 Preview 3.
After verifying that the test compiles cleanly and passes with our current development build of the compiler, I guarded it with
__cpp_lib_coroutine >= 201902L. This will be activated when MSVC updates the compiler macro__cpp_impl_coroutine(expected in VS 2019 16.8 Preview 3/4) and similarly for Clang/EDG.This test is incompatible with
/await, but #1207 is removing that from theusual_latest_matrix.lst.