Skip to content

Implement ranges::partial_sort and ranges::partial_sort_copy #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyCarter merged 5 commits into from
Sep 4, 2020
Merged

Implement ranges::partial_sort and ranges::partial_sort_copy #1231

CaseyCarter merged 5 commits into from
Sep 4, 2020

Conversation

@CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Aug 25, 2020

Partially addresses #39.

@CaseyCarter CaseyCarter added cxx20 C++20 feature ranges C++20/23 ranges labels Aug 25, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner August 25, 2020 18:24
@CaseyCarter CaseyCarter mentioned this pull request Aug 25, 2020
Closed
miscco
miscco reviewed Aug 25, 2020
View reviewed changes
miscco
miscco reviewed Aug 25, 2020
View reviewed changes
miscco
miscco reviewed Aug 25, 2020
View reviewed changes
miscco
miscco reviewed Aug 25, 2020
View reviewed changes
miscco
miscco reviewed Aug 25, 2020
View reviewed changes
miscco
miscco reviewed Aug 25, 2020
View reviewed changes
@miscco
Copy link
Contributor

miscco commented Aug 25, 2020

Looks good, there are mostly some formatting inconsistencies

@mnatsuhara mnatsuhara self-assigned this Aug 26, 2020
mnatsuhara
mnatsuhara reviewed Sep 1, 2020
View reviewed changes
CaseyCarter
CaseyCarter commented Sep 1, 2020
View reviewed changes
CaseyCarter and others added 2 commits September 1, 2020 13:48
@CaseyCarter @mnatsuhara
Apply suggestions from code review
eea1e01 
Co-authored-by: mnatsuhara <46756417+mnatsuhara@users.noreply.github.com>
@CaseyCarter
Test heterogeneous projections
769548a
StephanTLavavej
StephanTLavavej requested changes Sep 2, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, really minor nitpicks.

@CaseyCarter CaseyCarter self-assigned this Sep 4, 2020
@CaseyCarter CaseyCarter merged commit fcd8a62 into microsoft:master Sep 4, 2020
@CaseyCarter
Copy link
Contributor Author

CaseyCarter commented Sep 4, 2020

Thanks for completely implementing these range algorithms!

@CaseyCarter CaseyCarter deleted the partial_tsro branch September 4, 2020 18:33
@CaseyCarter CaseyCarter removed their assignment Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@miscco miscco miscco left review comments

@mnatsuhara mnatsuhara mnatsuhara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cxx20 C++20 feature ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CaseyCarter @miscco @StephanTLavavej @mnatsuhara