Skip to content

add bound check assertion to valarray::operator[] #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyCarter merged 1 commit into from
Sep 4, 2020
Merged

add bound check assertion to valarray::operator[] #1247

CaseyCarter merged 1 commit into from
Sep 4, 2020

Conversation

@Arzaghi
Copy link
Contributor

@Arzaghi Arzaghi commented Aug 29, 2020

Fixes #953

@Arzaghi Arzaghi marked this pull request as ready for review August 29, 2020 14:27
@Arzaghi Arzaghi requested a review from a team as a code owner August 29, 2020 14:27
@CaseyCarter CaseyCarter added the bug Something isn't working label Aug 29, 2020
@CaseyCarter CaseyCarter self-assigned this Sep 4, 2020
@CaseyCarter CaseyCarter merged commit 2521e64 into microsoft:master Sep 4, 2020
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Sep 4, 2020

Thanks for the bugfix!

@CaseyCarter CaseyCarter removed their assignment Sep 5, 2020
@Arzaghi Arzaghi deleted the Fix_Issue953 branch September 5, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@mnatsuhara mnatsuhara mnatsuhara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<valarray>: VS doesn't trigger the assertion when the data out of bound in std::valarray

4 participants

@Arzaghi @CaseyCarter @StephanTLavavej @mnatsuhara