Skip to content

Implement non-concepts fallback for coroutine_handle operator<=> #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaseyCarter merged 2 commits into from
Sep 2, 2020
Merged

Implement non-concepts fallback for coroutine_handle operator<=> #1249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dfb76e
Implement non-concepts fallback for coroutine_handle operator<=>
CaseyCarter Aug 31, 2020
e145b0b
Reorder feature-tests in `<experimental/generator>`
CaseyCarter Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion stl/inc/coroutine
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,11 @@ _NODISCARD constexpr bool operator==(const coroutine_handle<> _Left, const corou

_NODISCARD constexpr strong_ordering operator<=>(
const coroutine_handle<> _Left, const coroutine_handle<> _Right) noexcept {
return compare_three_way()(_Left.address(), _Right.address());
#ifdef __cpp_lib_concepts
return compare_three_way{}(_Left.address(), _Right.address());
#else // ^^^ no workaround / workaround vvv
return _Left.address() <=> _Right.address();
#endif // __cpp_lib_concepts
}

template <class _Promise>
Expand Down
16 changes: 8 additions & 8 deletions stl/inc/experimental/generator
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,19 @@
#include <yvals_core.h>
#if _STL_COMPILER_PREPROCESSOR

#if !defined(__cpp_coroutines) && !defined(__cpp_impl_coroutine)
#error <experimental/generator> requires /std:c++latest or /await compiler options
#endif // !defined(__cpp_coroutines) && !defined(__cpp_impl_coroutine)

#ifdef _CPPUNWIND
#include <exception>
#endif
#include <memory>
#ifdef __cpp_coroutines
#include <experimental/resumable>
#else // __cpp_coroutines

#if defined(__cpp_impl_coroutine)
#include <coroutine>
#endif // __cpp_coroutines
#elif defined(__cpp_coroutines)
#include <experimental/resumable>
#else // ^^^ legacy coroutines / no coroutine support vvv
#error <experimental/generator> requires /std:c++latest or /await compiler options
#endif // ^^^ no coroutine support ^^^


#pragma pack(push, _CRT_PACKING)
#pragma warning(push, _STL_WARNING_LEVEL)
Expand Down
1 change: 0 additions & 1 deletion tests/std/tests/VSO_0971246_legacy_await_headers/env.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ PM_CL="/EHsc /MT /std:c++latest /permissive-"
PM_CL="/EHsc /MT /std:c++latest /permissive"
PM_CL="/EHsc /MT /std:c++latest /permissive- /await"
PM_CL="/EHsc /MT /std:c++latest /permissive /await"
PM_CL="/BE /c /EHsc /MD /std:c++latest /permissive- /await"
PM_CL="/BE /c /EHsc /MD /std:c++latest /permissive-"