Implement views::filter #1252
Merged
Implement views::filter #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
added
cxx20
miscco
reviewed
Sep 1, 2020
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
I came until the tests some smaller nits
Closed
StephanTLavavej
requested changes
Sep 2, 2020
CaseyCarter
commented
Sep 2, 2020
StephanTLavavej
approved these changes
Sep 2, 2020
StephanTLavavej
approved these changes
Sep 2, 2020
miscco
reviewed
Sep 3, 2020
StephanTLavavej
approved these changes
Sep 3, 2020
StephanTLavavej
approved these changes
Sep 3, 2020
Contributor
Author
|
Finally, a way to remove unwanted chaff from our ranges. The world truly owes you a debt of gratitude for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocates
ranges::find_iffrom<algorithm>to<xutility>so it can be used inranges::filter_viewwithout including<algorithm>. Also implements the proposed resolution of LWG-3481 (a reformulation of the conceptviewable_range).The standard uses the name
basefor the non-static data member of view types that holds the underlying view, andBaseto name the (possibly-const) corresponding view type for custom iterators and sentinels. Trying to use the ugly_Basefor both purposes in our implementation is confusing, so I've decided to use_Rangefor the former case and_Basefor the latter. This PR renames the pertinent member ofreverse_viewto be consistent with this guideline.