Implement views::take and views::drop #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also implements the proposed resolution of LWG-3481.
CaseyCarter
added
cxx20
miscco
reviewed
Sep 1, 2020
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
I am toast so just one general question about the sentinel
Closed
StephanTLavavej
requested changes
Sep 2, 2020
CaseyCarter
commented
Sep 2, 2020
miscco
reviewed
Sep 2, 2020
StephanTLavavej
approved these changes
Sep 2, 2020
StephanTLavavej
approved these changes
Sep 3, 2020
cbezault
approved these changes
Sep 4, 2020
Contributor
Author
|
Thanks for taking the time to drop this contribution on us! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
<iterator>: Implement the proposed resolutions of LWG-3391 and LWG-3481. Conditionally specializepointer_traitssocounted_iterator<I>modelscontiguous_iteratorwhenImodelscontiguous_iterator(this will be part of the resolution of LWG-3408 when I can find some time to finish proposed wording).<xutility>: Conditionalnoexceptforranges::distanceandmove_iterator::base.<range_algorithm_support.hpp>: Bugfix to allowtest::iteratorto properly model move-only output iterators. (We can't return a copy of the iterator from post-increment to make*meow++ = woofwork, we need a proxy reference type.)