P0896R4 stream iterator changes #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affects `istream_iterator`, `ostream_iterator`, `istreambuf_iterator`, and `ostreambuf_iterator`.
Closed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
approved these changes
Sep 17, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Approved with a handful of nitpicks and one significant question about noexcept strengthening. Thanks!
StephanTLavavej
approved these changes
Sep 17, 2020
mnatsuhara
approved these changes
Oct 5, 2020
Contributor
mnatsuhara
left a comment
mnatsuhara
left a comment
There was a problem hiding this comment.
Just one question on test coverage, otherwise looks great! :)
Contributor
Author
|
We love iterator changes because we're not iter-haters! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing exotic here, really, just adding default constructors and (for the output iterators) difference types so the stream iterators properly model the C++20 iterator concepts.
I did strengthen some
noexcepton my way through, and fixed what appears to be a longstanding bug:ostream_iterator's data members should beprivateinstead ofprotected.Partially addresses #39.