Skip to content

<filesystem>: create_directories() throw for empty paths #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 4 commits into from
Sep 25, 2020
Merged

<filesystem>: create_directories() throw for empty paths #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b36ebf
add test to cover the issue
Arzaghi Sep 10, 2020
44a5bf5
create_directory throw on empty path
Arzaghi Sep 10, 2020
d63731f
create_directory throw for empty paths
Arzaghi Sep 11, 2020
20fc68d
apply suggestions to the test
Arzaghi Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stl/inc/filesystem
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3750,6 +3750,11 @@ namespace filesystem {

// FUNCTION create_directories
inline bool create_directories(const path& _Path, error_code& _Ec) {
if (_Path.empty()) {
_Ec = _Make_ec(__std_win_error::_Path_not_found);
return false;
}

_Ec.clear(); // for exception safety
const wstring& _Text = _Path.native();
wstring _Tmp;
Expand Down
5 changes: 5 additions & 0 deletions tests/std/tests/P0218R1_filesystem/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3669,6 +3669,11 @@ void test_create_dirs_and_remove_all() {
remove_all(badPath, ec);
EXPECT(good(ec));

// test GH-1283 create_directories() should throw for empty paths
EXPECT(throws_filesystem_error([] { create_directories(path{}); }, "create_directories", path{}));
EXPECT(create_directories(path{}, ec) == false);
EXPECT(bad(ec));

// test that normalization isn't done first
auto dots = r / L"a/../b/../c"sv;
EXPECT(create_directories(dots));
Expand Down