Skip to content

Conversation

@SuperWig
Copy link
Contributor

Fixes #1152 and #1199

@SuperWig SuperWig requested a review from a team as a code owner September 15, 2020 08:51
@SuperWig
Copy link
Contributor Author

SuperWig commented Sep 15, 2020

Interesting, it only auto linked one of the issues, I guess it doesn't understand "and". 😕

I don't suppose there's a way to not run the tests when submitting a PR? Seems a bit of a wasted effort seeing as this depends on a yet to be merged update.

@CaseyCarter CaseyCarter linked an issue Sep 15, 2020 that may be closed by this pull request
@CaseyCarter CaseyCarter added blocked on 16.8p3 test Related to test code labels Sep 15, 2020
@cbezault
Copy link
Contributor

@StephanTLavavej
Copy link
Member

Interesting, it only auto linked one of the issues, I guess it doesn't understand "and".

That's correct - the Words Of Power must be repeated. See: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@StephanTLavavej

This comment has been minimized.

@cbezault

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@cbezault

This comment has been minimized.

@CaseyCarter

This comment has been minimized.

@StephanTLavavej StephanTLavavej self-assigned this Sep 22, 2020
@StephanTLavavej StephanTLavavej merged commit 8be9877 into microsoft:master Sep 23, 2020
@StephanTLavavej
Copy link
Member

Thanks for following up on these issues - removing workarounds helps our compilers stay conformant! 😸

@SuperWig SuperWig deleted the prev3 branch September 26, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove workaround for DevCom-1044530 Change libcxx SKIPPED to FAIL when MSVC ships P0960

4 participants