Pre-decay template arguments to _Front_binder #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
commented
Sep 15, 2020
miscco
reviewed
Sep 15, 2020
timsong-cpp
reviewed
Sep 16, 2020
StephanTLavavej
requested changes
Sep 17, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good - all I found were minor nitpicks as @timsong-cpp found the significant issue of copy constructor hijacking (which can be solved with SFINAE).
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good; I'll push one cleanup.
StephanTLavavej
approved these changes
Sep 17, 2020
barcharcraz
approved these changes
Sep 29, 2020
Member
|
Thanks for getting the STL ready to celebrate Halloween by adding a bit more decay! 💀 👻 🎃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1292.