Skip to content

Conversation

@StephanTLavavej
Copy link
Member

Followups to GH-1344 requested by @cbezault.

  • xutility
    • Extract && !defined(_M_ARM64EC) to the end for clarity. There's no behavioral change here (_M_ARM64EC can be defined only when _M_X64 is defined), it just separates the major architectures where we want to enable the vectorized algorithms (x86, x64) from the flavors where they should be excluded due to intrinsic unavailability.
  • stl/msbuild/stl_base/msvcp.settings.targets
  • stl/msbuild/stl_atomic_wait/stl_atomic_wait.files.settings.targets
    • Add and remove semicolons for consistency.
  • vector_algorithms.cpp
    • Adjust preprocessor guards. We never build this for /clr:pure, so that can be a hard #error. However, we do need to make this file a no-op for _M_ARM64EC. Extract that, like xutility above.

I tested this with MSVC-internal builds of x86, x64, arm, arm64, and chpe (there is no dedicated arm64ec build).

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 7, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner October 7, 2020 00:59
@StephanTLavavej

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@StephanTLavavej

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@StephanTLavavej

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@StephanTLavavej

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@StephanTLavavej

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@StephanTLavavej

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@StephanTLavavej

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@cbezault cbezault closed this Oct 7, 2020
@cbezault cbezault reopened this Oct 7, 2020
@cbezault cbezault closed this Oct 7, 2020
@cbezault cbezault reopened this Oct 7, 2020
@CaseyCarter

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@cbezault

This comment has been minimized.

@cbezault

This comment has been minimized.

@cbezault

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@cbezault cbezault closed this Oct 7, 2020
@cbezault cbezault reopened this Oct 7, 2020
@CaseyCarter

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@cbezault cbezault closed this Oct 7, 2020
@cbezault cbezault reopened this Oct 7, 2020
@cbezault cbezault closed this Oct 7, 2020
@cbezault cbezault reopened this Oct 7, 2020
@StephanTLavavej

This comment has been minimized.

1 similar comment
@cbezault

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

1 similar comment
@azure-pipelines

This comment has been minimized.

@StephanTLavavej StephanTLavavej added the uncharted Excluded from the Status Chart label Oct 8, 2020
@StephanTLavavej StephanTLavavej deleted the arm64ec_followup branch October 8, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved uncharted Excluded from the Status Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants