Prevent crash when custom streambuf implementation throws #1358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arzaghi
changed the title
barcharcraz
approved these changes
Nov 4, 2020
Contributor
barcharcraz
left a comment
barcharcraz
left a comment
There was a problem hiding this comment.
Approved with suggested changes
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks for fixing this bug! I'm planning to prepare a batch of PRs for merging, so I'll validate minor changes and push them in a few minutes.
StephanTLavavej
approved these changes
Nov 5, 2020
Member
|
FYI @barcharcraz, I pushed small changes after you approved. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Member
|
Thanks again - we really appreciate all of your fixes! 🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1105
Just pre-init some pointers and a numeric variable and also wrapping a pointer deletion with an
ifstatement could solve the issue.I wanted to add a test coverage and I didn't find any relative place to add the test. I've added a new folder for the new test. It's my first time that I'm adding a new folder to the tests folder. I've tried to follow the conventions. Excuse me if I missed anything here.