Add _CONTAINER_DEBUG_LEVEL checks for optional #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `_CONTAINER_DEBUG_LEVEL` is `1` (which is implied by `_ITERATOR_DEBUG_LEVEL != 0`) `optional::operator*` and `optional::operator->` verify the precondition that the `optional` is not empty. Drive-by: Add a default constructor to `death_test_executive` so we need not construct with a do-nothing function when there are no "normal" tests.
Member
|
LGTM |
|
I'm not understanding the STL good enough to give a review, but I like the feature. |
cbezault
approved these changes
Oct 9, 2020
StephanTLavavej
approved these changes
Oct 10, 2020
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
fengjixuchui
added a commit
to fengjixuchui/STL
that referenced
this pull request
Oct 13, 2020
Add _CONTAINER_DEBUG_LEVEL checks for optional (microsoft#1362)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
_CONTAINER_DEBUG_LEVELis1(which is implied by_ITERATOR_DEBUG_LEVEL != 0)optional::operator*andoptional::operator->verify the precondition that theoptionalis not empty.Drive-by: Add a default constructor to
death_test_executiveso we need not construct with a do-nothing function when there are no "normal" tests.Partially addresses #1359.