[feature/format] parse format specs #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpplearner
reviewed
Oct 22, 2020
CaseyCarter
suggested changes
Oct 28, 2020
mnatsuhara
assigned
CaseyCarter and
barcharcraz and unassigned
barcharcraz and
CaseyCarter
CaseyCarter
approved these changes
Nov 12, 2020
CaseyCarter
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds parse_format_specs, which implements the parsing of [format.string.std]
adds some tests for this, although there's some work that really needs to happen on the testing code (I'd like testing_callbacks to actually check if the thing was called, not just that it was called with the right value).