initializer_lists constructed using values #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks for fixing these unnecessarily nonconformant tests! Everything looks good to me, I just noticed one possible simplification and two extra newlines, so I'll push a small commit and move this forward to Final Review. 😺
StephanTLavavej
approved these changes
Oct 27, 2020
CaseyCarter
approved these changes
Oct 27, 2020
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Just one small change here that I'll apply directly.
Construct `discrete_distribution<>` from `initializer_list` as before.
StephanTLavavej
approved these changes
Oct 27, 2020
Member
|
Thanks for fixing this issue and eliminating unnecessary non-Standard code from the test suite! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I searched occurences of using
initializer_listaccording to issue #1184. In most casesinitializer_listis used for testinginitializer_listconstructors or it is required for constructing other object, so I just filled initializer_lists manually, in pair of cases I replaced themFixes #1184