Move from rvalue range adaptor closures #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have `const`-qualified member functions that attempt to move from member variables, which is at the very least confusing. This change splits the `operator() const` of `views::filter` and `views::transform`'s correspondng range adaptor closure objects into `const&`-qualified and `&&`-qualified overloads that copy and move from, respectively, the stashed function object.
CaseyCarter
commented
Oct 29, 2020
StephanTLavavej
approved these changes
Oct 29, 2020
StephanTLavavej
approved these changes
Oct 29, 2020
cbezault
approved these changes
Nov 4, 2020
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Member
|
Thanks for this cleanup and/or potential performance improvement! 🧹 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have
const-qualified member functions that attempt to move from member variables, which is at the very least confusing. This change splits theoperator() constofviews::filterandviews::transform's corresponding range adaptor closure objects intoconst&-qualified and&&-qualified overloads that copy and move from, respectively, the stashed function object.