Always remove_cvref_t the argument to enable_borrowed_range #1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... especially in these view tests.
miscco
reviewed
Nov 2, 2020
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Looks good, thanks for finding those
miscco
approved these changes
Nov 2, 2020
StephanTLavavej
approved these changes
Nov 3, 2020
StephanTLavavej
added
test
Member
|
Relabeling as I believe we should use bug for product bugs, not test bugs. |
mnatsuhara
approved these changes
Nov 5, 2020
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Member
|
Thanks again for fixing this! 🛠️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... especially in these view tests.
Found during review at #1305 (comment).