feature/format: Merge toolset update

.github/ISSUE_TEMPLATE/cxx20-feature.md → .github/ISSUE_TEMPLATE/cxx23-feature.md

@@ -1,8 +1,8 @@
 ---
-name: cxx20 Feature
+name: cxx23 Feature
 about: For STL maintainers only
 title: PAPER_NUMBER PAPER_TITLE
-labels: cxx20
+labels: cxx23
 assignees: ''
 
 ---
@@ -22,3 +22,8 @@ the https://wg21.link redirector will start working.
 
 Feature-test macro:
 `#define MACRO_NAME MACRO_VALUE`
+
+Note: We're still working on finishing C++20. Until we're done
+with that (and the compiler implements distinct `/std:c++20` and
+`/std:c++latest` options), we won't be able to review PRs for
+C++23 features.

CMakeLists.txt

@@ -5,7 +5,7 @@ if (NOT DEFINED CMAKE_TOOLCHAIN_FILE AND EXISTS "${CMAKE_CURRENT_LIST_DIR}/vcpkg
     set(CMAKE_TOOLCHAIN_FILE "${CMAKE_CURRENT_LIST_DIR}/vcpkg/scripts/buildsystems/vcpkg.cmake")
 endif()
 
-cmake_minimum_required(VERSION 3.17)
+cmake_minimum_required(VERSION 3.18)
 set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
 project(msvc_standard_libraries LANGUAGES CXX)
 

README.md

@@ -143,30 +143,30 @@ Just try to follow these rules, so we can spend more time fixing bugs and implem
 The STL uses boost-math headers to provide P0226R1 Mathematical Special Functions. We recommend using [vcpkg][] to
 acquire this dependency.
 
-1. Install Visual Studio 2019 16.8 Preview 5 or later.
+1. Install Visual Studio 2019 16.9 Preview 1 or later.
     * We recommend selecting "C++ CMake tools for Windows" in the VS Installer.
     This will ensure that you're using supported versions of CMake and Ninja.
-    * Otherwise, install [CMake][] 3.17 or later, and [Ninja][] 1.8.2 or later.
+    * Otherwise, install [CMake][] 3.18 or later, and [Ninja][] 1.8.2 or later.
 2. Open Visual Studio, and choose the "Clone or check out code" option. Enter the URL of this repository,
    `https://github.com/microsoft/STL`.
 3. Open a terminal in the IDE with `` Ctrl + ` `` (by default) or press on "View" in the top bar, and then "Terminal".
-4. In the terminal, invoke `git submodule update --init vcpkg`
+4. In the terminal, invoke `git submodule update --init --progress llvm-project vcpkg`
 5. In the terminal, invoke `.\vcpkg\bootstrap-vcpkg.bat`
 6. In the terminal, invoke `.\vcpkg\vcpkg.exe install boost-math:x86-windows boost-math:x64-windows`
 7. Choose the architecture you wish to build in the IDE, and build as you would any other project. All necessary CMake
    settings are set by `CMakeSettings.json`.
 
 # How To Build With A Native Tools Command Prompt
 
-1. Install Visual Studio 2019 16.8 Preview 5 or later.
+1. Install Visual Studio 2019 16.9 Preview 1 or later.
     * We recommend selecting "C++ CMake tools for Windows" in the VS Installer.
     This will ensure that you're using supported versions of CMake and Ninja.
-    * Otherwise, install [CMake][] 3.17 or later, and [Ninja][] 1.8.2 or later.
+    * Otherwise, install [CMake][] 3.18 or later, and [Ninja][] 1.8.2 or later.
 2. Open a command prompt.
 3. Change directories to a location where you'd like a clone of this STL repository.
 4. `git clone https://github.com/microsoft/STL`
 5. `cd STL`
-6. `git submodule update --init vcpkg`
+6. `git submodule update --init --progress llvm-project vcpkg`
 7. `.\vcpkg\bootstrap-vcpkg.bat`
 8. `.\vcpkg\vcpkg.exe install boost-math:x86-windows boost-math:x64-windows`
 
@@ -234,13 +234,12 @@ C:\Users\username\Desktop>dumpbin /IMPORTS .\example.exe | findstr msvcp
 # How To Run The Tests With A Native Tools Command Prompt
 
 1. Follow either [How To Build With A Native Tools Command Prompt][] or [How To Build With The Visual Studio IDE][].
-2. Invoke `git submodule update --init llvm-project` at the root of the STL source tree.
-3. Acquire [Python][] 3.9 or newer and have it on the `PATH` (or run it directly using its absolute or relative path).
-4. Have LLVM's `bin` directory on the `PATH` (so `clang-cl.exe` is available).
+2. Acquire [Python][] 3.9 or newer and have it on the `PATH` (or run it directly using its absolute or relative path).
+3. Have LLVM's `bin` directory on the `PATH` (so `clang-cl.exe` is available).
     * We recommend selecting "C++ Clang tools for Windows" in the VS Installer. This will automatically add LLVM to the
     `PATH` of the x86 and x64 Native Tools Command Prompts, and will ensure that you're using a supported version.
     * Otherwise, use [LLVM's installer][] and choose to add LLVM to your `PATH` during installation.
-5. Follow the instructions below.
+4. Follow the instructions below.
 
 ## Running All The Tests
 
@@ -397,7 +396,7 @@ SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 [CMake]: https://cmake.org/download
 [Code of Conduct FAQ]: https://opensource.microsoft.com/codeofconduct/faq/
 [Compiler Explorer]: https://godbolt.org
-[Developer Community]: https://developercommunity.visualstudio.com/spaces/62/index.html
+[Developer Community]: https://aka.ms/feedback/report?space=62
 [Discord server]: https://discord.gg/XWanNww
 [How To Build With A Native Tools Command Prompt]: #how-to-build-with-a-native-tools-command-prompt
 [How To Build With The Visual Studio IDE]: #how-to-build-with-the-visual-studio-ide
@@ -409,7 +408,7 @@ SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 [N4868]: https://wg21.link/n4868
 [NOTICE.txt]: NOTICE.txt
 [Ninja]: https://ninja-build.org
-[Pipelines]: https://dev.azure.com/vclibs/STL/_build/latest?definitionId=2&branchName=master
+[Pipelines]: https://dev.azure.com/vclibs/STL/_build/latest?definitionId=4&branchName=master
 [Python]: https://www.python.org/downloads/windows/
 [Roadmap]: https://github.com/microsoft/STL/wiki/Roadmap
 [Status Chart]: https://microsoft.github.io/STL/

azure-devops/create-vmss.ps1

@@ -25,7 +25,7 @@ $LiveVMPrefix = 'BUILD'
 $WindowsServerSku = '2019-Datacenter'
 
 $ProgressActivity = 'Creating Scale Set'
-$TotalProgress = 11
+$TotalProgress = 12
 $CurrentProgress = 1
 
 <#
@@ -159,6 +159,14 @@ function Wait-Shutdown {
 }
 
 
+####################################################################################################
+Write-Progress `
+  -Activity $ProgressActivity `
+  -Status 'Setting the subscription context' `
+  -PercentComplete (100 / $TotalProgress * $CurrentProgress++)
+
+Set-AzContext -SubscriptionName CPP_STL_GitHub
+
 ####################################################################################################
 Write-Progress `
   -Activity $ProgressActivity `
@@ -391,6 +399,4 @@ New-AzVmss `
 Write-Progress -Activity $ProgressActivity -Completed
 Write-Host "Location: $Location"
 Write-Host "Resource group name: $ResourceGroupName"
-Write-Host "User name: AdminUser"
-Write-Host "Using generated password: $AdminPW"
 Write-Host 'Finished!'

azure-devops/provision-image.ps1

@@ -88,6 +88,9 @@ $Workloads = @(
   'Microsoft.VisualStudio.Component.VC.CMake.Project',
   'Microsoft.VisualStudio.Component.VC.CoreIde',
   'Microsoft.VisualStudio.Component.VC.Llvm.Clang',
+  'Microsoft.VisualStudio.Component.VC.Runtimes.ARM.Spectre',
+  'Microsoft.VisualStudio.Component.VC.Runtimes.ARM64.Spectre',
+  'Microsoft.VisualStudio.Component.VC.Runtimes.x86.x64.Spectre',
   'Microsoft.VisualStudio.Component.VC.Tools.ARM',
   'Microsoft.VisualStudio.Component.VC.Tools.ARM64',
   'Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
@@ -99,6 +102,9 @@ $Sku = 'Enterprise'
 $VisualStudioBootstrapperUrl = 'https://aka.ms/vs/16/pre/vs_enterprise.exe'
 $PythonUrl = 'https://www.python.org/ftp/python/3.9.0/python-3.9.0-amd64.exe'
 
+# https://docs.microsoft.com/en-us/windows-hardware/drivers/download-the-wdk
+$WindowsDriverKitUrl = 'https://go.microsoft.com/fwlink/?linkid=2128854'
+
 $CudaUrl = `
   'https://developer.download.nvidia.com/compute/cuda/10.1/Prod/local_installers/cuda_10.1.243_426.00_win10.exe'
 $CudaFeatures = 'nvcc_10.1 cuobjdump_10.1 nvprune_10.1 cupti_10.1 gpu_library_advisor_10.1 memcheck_10.1 ' + `
@@ -223,6 +229,36 @@ Function InstallPython {
   }
 }
 
+<#
+.SYNOPSIS
+Installs the Windows Driver Kit.
+
+.DESCRIPTION
+InstallWindowsDriverKit installs the Windows Driver Kit from the supplied URL.
+
+.PARAMETER Url
+The URL of the Windows Driver Kit installer.
+#>
+Function InstallWindowsDriverKit {
+  Param(
+    [String]$Url
+  )
+
+  Write-Host 'Downloading the Windows Driver Kit...'
+  [string]$installerPath = Get-TempFilePath -Extension 'exe'
+  curl.exe -L -o $installerPath -s -S $Url
+  Write-Host 'Installing the Windows Driver Kit...'
+  $proc = Start-Process -FilePath $installerPath -ArgumentList `
+  @('/quiet', '/features', 'OptionId.WindowsDriverKitComplete') -Wait -PassThru
+  $exitCode = $proc.ExitCode
+  if ($exitCode -eq 0) {
+    Write-Host 'Installation successful!'
+  }
+  else {
+    Write-Error "Installation failed! Exited with $exitCode."
+  }
+}
+
 <#
 .SYNOPSIS
 Installs NVIDIA's CUDA Toolkit.
@@ -300,6 +336,7 @@ Add-MpPreference -ExclusionProcess python.exe
 
 InstallPython $PythonUrl
 InstallVisualStudio -Workloads $Workloads -BootstrapperUrl $VisualStudioBootstrapperUrl
+InstallWindowsDriverKit $WindowsDriverKitUrl
 InstallCuda -Url $CudaUrl -Features $CudaFeatures
 
 Write-Host 'Updating PATH...'

azure-devops/run-build.yml

@@ -2,12 +2,13 @@
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 jobs:
-- job: ${{ parameters.targetPlatform }}
+- job: '${{ parameters.targetPlatform }}_${{ parameters.shardNum }}'
   timeoutInMinutes: 360
 
   variables:
     buildOutputLocation: 'D:\build\${{ parameters.targetPlatform }}'
     litFlags: '-j$(testParallelism);--timeout=240;--shuffle;--xunit-xml-output=$(buildOutputLocation)/test-results.xml'
+    shardFlags: '--num-shards=${{ parameters.numShards }};--run-shard=${{ parameters.shardNum }}'
     vcpkgLocation: '$(Build.SourcesDirectory)/vcpkg'
   steps:
     - script: |
@@ -62,8 +63,8 @@ jobs:
         -host_arch=amd64 -arch=${{ parameters.vsDevCmdArch }} -no_logo
         cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=$(vcpkgLocation)\scripts\buildsystems\vcpkg.cmake ^
         -DVCPKG_TARGET_TRIPLET=${{ parameters.targetPlatform }}-windows -DCMAKE_CXX_COMPILER=cl ^
-        -DCMAKE_BUILD_TYPE=Release -DLIT_FLAGS=$(litFlags) ^
-        -DCMAKE_CXX_FLAGS=/analyze ^
+        -DCMAKE_BUILD_TYPE=Release -DLIT_FLAGS=$(litFlags);$(shardFlags) ^
+        -DCMAKE_CXX_FLAGS=/analyze:autolog- ^
         -S $(Build.SourcesDirectory) -B $(buildOutputLocation)
         cmake --build $(buildOutputLocation)
       displayName: 'Build the STL'
@@ -88,4 +89,4 @@ jobs:
         searchFolder: $(buildOutputLocation)
         testResultsFormat: JUnit
         testResultsFiles: '**/test-results.xml'
-        testRunTitle: 'test-${{ parameters.targetPlatform }}'
+        testRunTitle: 'test-${{ parameters.targetPlatform }}-${{ parameters.shardNum }}'

azure-pipelines.yml

@@ -6,7 +6,7 @@
 variables:
   tmpDir: 'D:\Temp'
 
-pool: 'StlBuild-2020-10-23'
+pool: 'StlBuild-2020-11-10'
 
 stages:
   - stage: Code_Format
@@ -63,18 +63,124 @@ stages:
         parameters:
           targetPlatform: x86
           vsDevCmdArch: x86
+          numShards: 8
+          shardNum: 1
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x86
+          vsDevCmdArch: x86
+          numShards: 8
+          shardNum: 2
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x86
+          vsDevCmdArch: x86
+          numShards: 8
+          shardNum: 3
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x86
+          vsDevCmdArch: x86
+          numShards: 8
+          shardNum: 4
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x86
+          vsDevCmdArch: x86
+          numShards: 8
+          shardNum: 5
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x86
+          vsDevCmdArch: x86
+          numShards: 8
+          shardNum: 6
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x86
+          vsDevCmdArch: x86
+          numShards: 8
+          shardNum: 7
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x86
+          vsDevCmdArch: x86
+          numShards: 8
+          shardNum: 8
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x64
+          vsDevCmdArch: amd64
+          numShards: 8
+          shardNum: 1
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x64
+          vsDevCmdArch: amd64
+          numShards: 8
+          shardNum: 2
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x64
+          vsDevCmdArch: amd64
+          numShards: 8
+          shardNum: 3
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x64
+          vsDevCmdArch: amd64
+          numShards: 8
+          shardNum: 4
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x64
+          vsDevCmdArch: amd64
+          numShards: 8
+          shardNum: 5
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x64
+          vsDevCmdArch: amd64
+          numShards: 8
+          shardNum: 6
+
+      - template: azure-devops/run-build.yml
+        parameters:
+          targetPlatform: x64
+          vsDevCmdArch: amd64
+          numShards: 8
+          shardNum: 7
 
       - template: azure-devops/run-build.yml
         parameters:
           targetPlatform: x64
           vsDevCmdArch: amd64
+          numShards: 8
+          shardNum: 8
 
       - template: azure-devops/run-build.yml
         parameters:
           targetPlatform: arm
           vsDevCmdArch: arm
+          numShards: 1
+          shardNum: 1
 
       - template: azure-devops/run-build.yml
         parameters:
           targetPlatform: arm64
           vsDevCmdArch: arm64
+          numShards: 1
+          shardNum: 1

stl/aliases/generate.cmd

@@ -44,8 +44,7 @@ mkdir arm64ec
   chpe\std_init_once_begin_initialize.obj
 ..\..\..\..\..\tools\amd64\aliasobj.exe ^
   /machine:arm64ec ^
-  __imp___std_init_once_begin_initialize ^
-  __imp_InitOnceBeginInitialize ^
+  -m std_init_once_begin_initialize-arm64ec.txt ^
   arm64ec\std_init_once_begin_initialize.obj
 
 :: __std_init_once_complete
@@ -72,6 +71,5 @@ mkdir arm64ec
   chpe\std_init_once_complete.obj
 ..\..\..\..\..\tools\amd64\aliasobj.exe ^
   /machine:arm64ec ^
-  __imp___std_init_once_complete ^
-  __imp_InitOnceComplete ^
+  -m std_init_once_complete-arm64ec.txt ^
   arm64ec\std_init_once_complete.obj

stl/aliases/std_init_once_begin_initialize-arm64ec.txt

@@ -0,0 +1,2 @@
+#__std_init_once_begin_initialize #InitOnceBeginInitialize
+__imp___std_init_once_begin_initialize __imp_InitOnceBeginInitialize

stl/aliases/std_init_once_complete-arm64ec.txt

@@ -0,0 +1,2 @@
+#__std_init_once_complete #InitOnceComplete
+__imp___std_init_once_complete __imp_InitOnceComplete