Skip to content

<regex>: Fixes regex character class case insensitive search problem #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 7 commits into from
Dec 17, 2020
Merged

<regex>: Fixes regex character class case insensitive search problem #1503

StephanTLavavej merged 7 commits into from
Dec 17, 2020

Conversation

@Arzaghi
Copy link
Contributor

@Arzaghi Arzaghi commented Nov 28, 2020

Fixes #993

@Arzaghi Arzaghi marked this pull request as ready for review November 29, 2020 00:32
@Arzaghi Arzaghi requested a review from a team as a code owner November 29, 2020 00:32
@CaseyCarter CaseyCarter added the bug Something isn't working label Nov 30, 2020
StephanTLavavej
StephanTLavavej reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this bug! I'll push one more test case and trivial stylistic changes to make test_regex and test_wregex even more similar.

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 15, 2020

@Arzaghi @barcharcraz I've pushed a merge with master which applied clang-format 11 to this code. The added indentation caused annoying wrapping of the newly added line here, so I extracted the _Uelem typedef to make it more readable - no behavioral changes. (In fact I didn't bother to build/test, so let's see if I can get away with it...)

@StephanTLavavej StephanTLavavej merged commit 628544c into microsoft:master Dec 17, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 17, 2020

THANKS For fixing ThIs cAsE INSENSITIVE Bug! 😹

@Arzaghi Arzaghi deleted the Fix_Issue993 branch December 17, 2020 23:10
@StephanTLavavej StephanTLavavej added the regex meow is a substring of homeowner label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@barcharcraz barcharcraz barcharcraz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working regex meow is a substring of homeowner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<regex>: c++ regex character class case insensitive search problem

4 participants

@Arzaghi @StephanTLavavej @barcharcraz @CaseyCarter