Allow discarding unique_lock and shared_lock #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To unbreak RWC which uses the exact "return a lock from a function to allow the caller to do more work before unlocking" use case we were worried about.
CaseyCarter
commented
Dec 3, 2020
CaseyCarter
commented
Dec 3, 2020
cbezault
approved these changes
Dec 3, 2020
StephanTLavavej
requested changes
Dec 3, 2020
StephanTLavavej
approved these changes
Dec 3, 2020
StephanTLavavej
changed the title
Member
|
Thanks for fixing this Real World Code and ensuring that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unbreak RWC which uses the exact "return a lock from a function to allow the caller to do more work before unlocking" use case we were worried about.
Fixes VSO-1253916/AB#1253916.