Skip to content

Add an nvcc test which compiles all the headers at once #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 18 commits into from
Dec 17, 2020
Merged

Add an nvcc test which compiles all the headers at once #1519

StephanTLavavej merged 18 commits into from
Dec 17, 2020

Conversation

@cbezault
Copy link
Contributor

@cbezault cbezault commented Dec 9, 2020 •
edited
Loading

Fixes #639

This PR also changes the mechanism by which we detect tests. We now recognize any file ending with compile.pass.cpp or test.cpp under tr1/tests and std/tests as a test. The test.lst files are now only for internal usage.

@cbezault cbezault requested a review from a team as a code owner December 9, 2020 00:09
@cbezault cbezault changed the title Add an nvcc test run to the include each header alone test Add an nvcc test which compiles all the headers at once Dec 9, 2020
@cbezault cbezault added the test Related to test code label Dec 9, 2020
@StephanTLavavej StephanTLavavej self-assigned this Dec 9, 2020
CaseyCarter
CaseyCarter suggested changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these "requested changes" may actually be "requested explanation" ;)

@cbezault cbezault requested a review from CaseyCarter December 11, 2020 06:01
CaseyCarter
CaseyCarter approved these changes Dec 12, 2020
View reviewed changes
StephanTLavavej
StephanTLavavej requested changes Dec 12, 2020
View reviewed changes
@StephanTLavavej StephanTLavavej removed their assignment Dec 12, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 15, 2020

Everything looks great. I've pushed a merge with master, no conflicts.

@StephanTLavavej StephanTLavavej self-assigned this Dec 16, 2020
@StephanTLavavej StephanTLavavej merged commit 839c21c into microsoft:master Dec 17, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 17, 2020

Thanks for figuring out the necessary magic to improve our CUDA coverage! 🔮 😻

@StephanTLavavej StephanTLavavej mentioned this pull request Jan 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

test Related to test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests/std: Harness CUDA/NVCC

3 participants

@cbezault @StephanTLavavej @CaseyCarter