Convert contiguous_iterators to pointers correctly #1527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... even in std algorithms that optimize general `contiguous_iterator`s. Fixes microsoft#1523.
Contributor
|
#1433 contains another fix |
Member
|
@CaseyCarter says that this PR should be merged first, and then #1433 should be merged on top of this, since this is a targeted fix. |
cbezault
approved these changes
Dec 21, 2020
Member
|
I've pushed a merge; this PR was editing |
StephanTLavavej
approved these changes
Jan 6, 2021
Member
|
FYI @cbezault, I pushed minor changes after you approved. |
Member
|
FYI @cbezault I pushed changes again, so that the tests will pass in the MSVC-internal repo (which insists on linking and running all executables, whereas you had taught the GitHub test harness to skip linking/running |
Member
|
Thanks for fixing this bug! 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... even in std algorithms that optimize general
contiguous_iterators.Fixes #1523.