_NODISCARD for <hash_map> and <hash_set> #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Jan 17, 2021
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Looks reasonable, however, these files will be removed with the vNext rbanch https://github.com/microsoft/STL/wiki/vNext-Planning
Contributor
Author
|
Oh well 😄 |
Member
|
While we are indeed planning to remove |
futuarmo
approved these changes
Jan 19, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good, thanks! I'll go ahead and push changes for the two issues (one stylistic) that I found.
StephanTLavavej
approved these changes
Jan 23, 2021
cbezault
approved these changes
Jan 26, 2021
Member
|
Thanks for adding even more occurrences of the best attribute ever to the STL! All shall love |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further addresses #206.
Even though it's deprecated, it's still in the codebase, and I've found some member functions that seemingly can be marked as
_NODISCARD.Also, I'm very unsure about the helper functions, so if I missed anything in there that can be marked
_NODISCARDor has to be removed somewhere, then please let me know.