-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Toolset update: VS 2019 16.9 Preview 3 #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 14 commits into
microsoft:master
from
StephanTLavavej:fix_vm_script
Jan 22, 2021
Merged
Toolset update: VS 2019 16.9 Preview 3 #1577
StephanTLavavej
merged 14 commits into
microsoft:master
from
StephanTLavavej:fix_vm_script
Jan 22, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSO-1268140 "EDG: weirdness evaluating rvalue-qualified constexpr member function"
miscco
approved these changes
Jan 21, 2021
Contributor
miscco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
CaseyCarter
approved these changes
Jan 21, 2021
mnatsuhara
approved these changes
Jan 22, 2021
This was referenced Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure-devops/provision-image.ps1PsExec64.exeby downloading and extractingPSTools.zip, which is apparently recommended over directly downloading the executable.-UseMinimalHeadertoStart-Transcript, which reduces log verbosity.Function DownloadAndExtractZip.AdminUserPasswordwhen printing logs.-ioption when using-h. (Without it, the script fails with a difficult-to-understand error.)pip installprints useful information in the transcript (yay) but also a noisy progress bar that does us no good (because we only see the transcript when everything is done). So, runpip installwith--progress-bar off.bcdeditto enable test-signed kernel-mode drivers. (Works towards Kernel mode test harness #1421, untested here.)azure-devops/create-vmss.ps1SuppressAzurePowerShellBreakingChangeWarnings; this noise has never been useful to us.README.mdCMakeLists.txtazure-pipelines.ymltests/std/tests/P0220R1_optional/test.cpp