Add tests for basic_format_parse_context #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
Jan 30, 2021
tests/std/tests/P0645R10_text_formatting_parse_contexts/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0645R10_text_formatting_parse_contexts/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0645R10_text_formatting_parse_contexts/test.cpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
NOTE: I think I found a bug in clang-11. However it looks like it is already fixed in HEAD, does someone has a clang-12 lying around? |
Contributor
Author
|
@StephanTLavavej I did some more changes, it might be good to have another look |
miscco
commented
Jan 30, 2021
cpplearner
reviewed
Jan 30, 2021
Co-authored-by: S. B. Tam <cpplearner@outlook.com>
barcharcraz
suggested changes
Feb 4, 2021
StephanTLavavej
approved these changes
Feb 5, 2021
barcharcraz
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for basic_format_parse_context and fixes some preexisting issues