Skip to content

<random>: Fix min/max of a few random distributions and gamma_distribution::param_type::operator== #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 5 commits into from
Feb 12, 2021
Merged

<random>: Fix min/max of a few random distributions and gamma_distribution::param_type::operator== #1601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63aeb51
Fix normal_distribution::min and lognormal_distribution::min
statementreply Jan 30, 2021
b68cb4b
Fix extreme_value_distribution::min
statementreply Jan 30, 2021
c0d0571
Return Inf for min/max of unbounded real random distributions
statementreply Jan 30, 2021
a878d5a
Fix comparison of gamma_distribution::param_type
statementreply Jan 30, 2021
d969580
Update libcxx skip
statementreply Jan 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions stl/inc/random
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2780,7 +2780,7 @@ public:
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() {} // clear internal state
Expand Down Expand Up @@ -2917,11 +2917,11 @@ public:
}

_NODISCARD result_type(min)() const { // get smallest possible result
return numeric_limits<result_type>::denorm_min();
return -numeric_limits<result_type>::infinity();
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() { // clear internal state
Expand Down Expand Up @@ -3057,7 +3057,7 @@ public:
}

_NODISCARD bool operator==(const param_type& _Right) const {
return _Px == _Right._Px;
return _Alpha == _Right._Alpha && _Beta == _Right._Beta;
}

_NODISCARD bool operator!=(const param_type& _Right) const {
Expand Down Expand Up @@ -3111,11 +3111,11 @@ public:
}

_NODISCARD result_type(min)() const { // get smallest possible result
return numeric_limits<result_type>::denorm_min();
return result_type{0.0};
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() {} // clear internal state
Expand Down Expand Up @@ -3306,7 +3306,7 @@ public:
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() {} // clear internal state
Expand Down Expand Up @@ -3438,11 +3438,11 @@ public:
}

_NODISCARD result_type(min)() const { // get smallest possible result
return (numeric_limits<result_type>::min)();
return -numeric_limits<result_type>::infinity();
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() {} // clear internal state
Expand Down Expand Up @@ -3576,11 +3576,11 @@ public:
}

_NODISCARD result_type(min)() const { // get smallest possible result
return -(numeric_limits<result_type>::max)();
return result_type{0.0};
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() {} // clear internal state
Expand Down Expand Up @@ -3702,11 +3702,11 @@ public:
}

_NODISCARD result_type(min)() const { // get smallest possible result
return numeric_limits<result_type>::denorm_min();
return result_type{0.0};
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() {} // clear internal state
Expand Down Expand Up @@ -3834,11 +3834,11 @@ public:
}

_NODISCARD result_type(min)() const { // get smallest possible result
return -(numeric_limits<result_type>::max)();
return -numeric_limits<result_type>::infinity();
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() {} // clear internal state
Expand Down Expand Up @@ -4035,7 +4035,7 @@ public:
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() {} // clear internal state
Expand Down Expand Up @@ -4168,11 +4168,11 @@ public:
}

_NODISCARD result_type(min)() const { // get smallest possible result
return -(numeric_limits<result_type>::max)();
return -numeric_limits<result_type>::infinity();
}

_NODISCARD result_type(max)() const { // get largest possible result
return (numeric_limits<result_type>::max)();
return numeric_limits<result_type>::infinity();
}

void reset() {} // clear internal state
Expand Down
18 changes: 0 additions & 18 deletions tests/libcxx/expected_results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,34 +818,16 @@ std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.geo/eval_param.pass.cpp
std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.geo/eval.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.negbin/eval_param.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.cauchy/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.cauchy/min.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.chisq/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.chisq/min.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.f/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/eval_param.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/eval.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/min.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.normal/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.normal/min.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/eval_param.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/eval.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/min.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.exp/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/eval_param.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/eval.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/min.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eq.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eval_param.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eval.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/min.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.poisson/eval_param.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.poisson/eval.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.weibull/max.pass.cpp FAIL
std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.real/param_ctor.pass.cpp FAIL

# Not yet analyzed, likely STL bugs. Various assertions.
Expand Down
18 changes: 0 additions & 18 deletions tests/libcxx/skipped_tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,34 +818,16 @@ numerics\rand\rand.dis\rand.dist.bern\rand.dist.bern.geo\eval_param.pass.cpp
numerics\rand\rand.dis\rand.dist.bern\rand.dist.bern.geo\eval.pass.cpp
numerics\rand\rand.dis\rand.dist.bern\rand.dist.bern.negbin\eval_param.pass.cpp
numerics\rand\rand.dis\rand.dist.bern\rand.dist.bern.negbin\eval.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.cauchy\max.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.cauchy\min.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.chisq\max.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.chisq\min.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.f\max.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.lognormal\eval_param.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.lognormal\eval.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.lognormal\max.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.lognormal\min.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.normal\max.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.normal\min.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.t\eval_param.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.t\eval.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.t\max.pass.cpp
numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.t\min.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.exp\max.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.extreme\eval_param.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.extreme\eval.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.extreme\max.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.extreme\min.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\eq.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\eval_param.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\eval.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\max.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\min.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.poisson\eval_param.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.poisson\eval.pass.cpp
numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.weibull\max.pass.cpp
numerics\rand\rand.dis\rand.dist.uni\rand.dist.uni.real\param_ctor.pass.cpp

# Not yet analyzed, likely STL bugs. Various assertions.
Expand Down