-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<iomanip>: get_time handles leading zeros incorrectly #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also: - failbit should be set if the stream is EOF while not parsing a specifier. - A '%' at the end of a format string is an error, not a literal. - Reads leading spaces, in addition to leading zeros.
|
In #1606 (comment), @StephanTLavavej noted
This appears to be the product of a perhaps-unintended interaction between [locale.time.get.members]/8 and [locale.time.get.virtuals]/12. The later requires only |
more consistency with existing test code style
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think I'm following all of the logic here (I especially like how it mirrors the Standardese more closely now), and the added test coverage is great (along with the fact that none of the existing tests are affected). I was the most curious about counting spaces as digits, but that appears to handle the final test case and the strptime wording. I'll push a couple of commits for WP citations and consistent case-insensitive comparisons, then I think this is ready for final review.
|
Thanks for fixing these bugs - parsing times without delimiters has been a top customer request! 🎉 📅 ⌚ 😺 |
Fixes #1606. Also: