feature/spaceship: Clause 26: Numerics #1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
changed the title
StephanTLavavej
requested changes
Feb 5, 2021
statementreply
suggested changes
Feb 6, 2021
AnjuDel
force-pushed
the
spacechip_numeric
branch
from
40dab94 to
f4d6816
Compare
AnjuDel
force-pushed
the
spacechip_numeric
branch
from
f4d6816 to
4466b06
Compare
StephanTLavavej
requested changes
Feb 10, 2021
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
…to spacechip_numeric
AnjuDel
force-pushed
the
spacechip_numeric
branch
from
a002867 to
7919ddc
Compare
AnjuDel
force-pushed
the
spacechip_numeric
branch
from
ab1b533 to
cccc328
Compare
StephanTLavavej
approved these changes
Feb 12, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks, this looks great! I've pushed changes for two stylistic issues:
- Change the
#endifcomment in<valarray>to match the#ifthere. - In the test, directly construct
std::slice a1(2, 3, 4);instead of constructing a temporary. Both are correct, but direct construction avoids repeating the type name.
Member
|
Congratulations on your first microsoft/STL commit! 🎉 😸 🛸 |
Member
Author
Thanks STL 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #62.