Skip to content

Fix reliability issues in the parallelize tool #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 2 commits into from
Feb 18, 2021
Merged

Fix reliability issues in the parallelize tool #1632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
458e91e
Fix reliability issues in the parallelize tool
gix Feb 4, 2021
8209488
Add comment to running.exchange(false).
StephanTLavavej Feb 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tools/inc/stljobs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,16 @@ inline handle<invalid_handle_value_policy> create_file(LPCWSTR lpFileName, DWORD
return result;
}

inline handle<null_handle_policy> create_event(
LPSECURITY_ATTRIBUTES lpEventAttributes, BOOL bManualReset, BOOL bInitialState, LPCWSTR lpName) {
handle<null_handle_policy> result{CreateEventW(lpEventAttributes, bManualReset, bInitialState, lpName)};
if (!result) {
api_failure("CreateEventW");
}

return result;
}

inline handle<invalid_handle_value_policy> create_named_pipe(LPCWSTR lpName, DWORD dwOpenMode, DWORD dwPipeMode,
DWORD nMaxInstances, DWORD nOutBufferSize, DWORD nInBufferSize, DWORD nDefaultTimeOut,
LPSECURITY_ATTRIBUTES lpSecurityAttributes) {
Expand Down Expand Up @@ -305,14 +315,17 @@ struct output_collecting_pipe {
writeHandle = create_file(pipeNameBuffer, GENERIC_WRITE | FILE_READ_ATTRIBUTES, 0, &inheritSa, OPEN_EXISTING,
FILE_FLAG_OVERLAPPED, HANDLE{});

readEvent = create_event(nullptr, TRUE, FALSE, nullptr);
overlapped.hEvent = readEvent.get();

readIo = tp_io{std::move(readHandle), callback, this, nullptr};

start();
}

~output_collecting_pipe() noexcept {
if (readIo) {
if (running.load()) {
if (running.exchange(false)) { // prevent callback() from calling read_some()
if (!CancelIoEx(readIo.get_file(), &overlapped)) {
api_failure("CancelIoEx"); // slams into noexcept
}
Expand Down Expand Up @@ -413,6 +426,7 @@ struct output_collecting_pipe {
std::string targetBuffer; // if running, owned by a threadpool thread, otherwise owned by the calling thread
size_t validTill{};
handle<invalid_handle_value_policy> writeHandle;
handle<null_handle_policy> readEvent;
tp_io readIo;
OVERLAPPED overlapped{};
};
Expand Down