Comment calendar date conversion algorithm #1646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnatsuhara
approved these changes
Feb 19, 2021
Contributor
mnatsuhara
left a comment
mnatsuhara
left a comment
There was a problem hiding this comment.
Thanks so much for adding these clarifying these comments! These help hugely in understanding the super-efficient formulas used. The only comments I have are grammar nit-picks, and they should not hold up merging 🥇
Co-authored-by: Miya Natsuhara <minatsuh@microsoft.com>
StephanTLavavej
approved these changes
Feb 21, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
This is an amazingly detailed explanation 😻 and it makes all of the other comments in the STL look comparatively worse 😹
Member
|
Thanks again for demystifying the ultra-fast math here! 🚀 🔎 💡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1641.
No functional code change.