Skip to content

Conversation

@barcharcraz
Copy link
Contributor

Tests various argumentless calls for vformat_to (the most core of the format functions) and tests that escaped curly braces are escaped correctly.

Fixes a bug caused by not changing "return" to "break" when inlining the _Writer_loop loop.

@barcharcraz barcharcraz requested a review from a team as a code owner February 19, 2021 01:58
@barcharcraz barcharcraz self-assigned this Feb 19, 2021
@StephanTLavavej StephanTLavavej added cxx20 C++20 feature format C++20/23 format labels Feb 19, 2021
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, mostly me nitpicking at pre-existing stuff in the context around the bug. (Feel free to merge without re-review, I can complain about checked-in code just as easily as code in a PR.)

Charles and others added 2 commits February 19, 2021 12:25
Co-authored-by: Casey Carter <cartec69@gmail.com>
@barcharcraz barcharcraz merged commit 99e8a2d into microsoft:feature/format Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cxx20 C++20 feature format C++20/23 format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants