Skip to content

Conversation

@jangzn
Copy link
Contributor

@jangzn jangzn commented Feb 19, 2021

I updated the readme according to what was proposed in issue #1659

@jangzn jangzn requested a review from a team as a code owner February 19, 2021 15:26
@CaseyCarter CaseyCarter added the documentation Related to documentation or comments label Feb 19, 2021
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@CaseyCarter CaseyCarter linked an issue Feb 19, 2021 that may be closed by this pull request
@CaseyCarter
Copy link
Contributor

I updated the readme according to what was proposed in issue #1659

For future reference, the issue would have been linked automagically if you'd put the phrase "Fixes #1659" somewhere in your commit message (See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword for details).

@StephanTLavavej
Copy link
Member

Status update: We simultaneously merge PRs on GitHub and in our Microsoft-internal repo. As this is a semi-manual process, we typically batch up a few PRs. Your PR will be in the next batch, probably early next week!

@jangzn
Copy link
Contributor Author

jangzn commented Feb 20, 2021

For future reference, the issue would have been linked automagically if you'd put the phrase "Fixes #1659" somewhere in your commit message (See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword for details).

Thank you @CaseyCarter, I'm going to make use of it in the future.

@StephanTLavavej thank you for the status update and for fixing the grammar issue.

@StephanTLavavej StephanTLavavej self-assigned this Feb 25, 2021
@StephanTLavavej StephanTLavavej merged commit 8a2c56d into microsoft:main Feb 26, 2021
@StephanTLavavej
Copy link
Member

Thanks for improving the README to avoid confusing readers, and congratulations on your first microsoft/STL commit! 🎉 📄 😸

@jangzn jangzn deleted the readme-test-options branch February 26, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README.md: /BE is supported for the tests, /clr isn't

3 participants