-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update outdated test options in readme (#1659) #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CaseyCarter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
For future reference, the issue would have been linked automagically if you'd put the phrase "Fixes #1659" somewhere in your commit message (See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword for details). |
|
Status update: We simultaneously merge PRs on GitHub and in our Microsoft-internal repo. As this is a semi-manual process, we typically batch up a few PRs. Your PR will be in the next batch, probably early next week! |
Thank you @CaseyCarter, I'm going to make use of it in the future. @StephanTLavavej thank you for the status update and for fixing the grammar issue. |
|
Thanks for improving the README to avoid confusing readers, and congratulations on your first microsoft/STL commit! 🎉 📄 😸 |
I updated the readme according to what was proposed in issue #1659