Enable constexpr_vector_bool internal testing #1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enables constexpr_vector_bool testing with `MSVC_INTERNAL_TESTING` * Adds a workaround to `_Orphan_range_unlocked` in `vector<bool>` * Fixes UB resulting from subtracting from a nullptr
miscco
approved these changes
Feb 25, 2021
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
I am not a fan of _Temp as a name. On the other hand I cannot give a better name and the whole code there is cursed.
LGTM
mnatsuhara
approved these changes
Feb 25, 2021
StephanTLavavej
approved these changes
Feb 25, 2021
Member
|
Thanks for improving this test coverage and fixing long-standing undefined behavior! 😻 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables constexpr_vector_bool testing with
MSVC_INTERNAL_TESTINGAdds a workaround to
_Orphan_range_unlockedinvector<bool>Fixes UB resulting from subtracting from a nullptr
Mirrors changes in MSVC-PR-306712.