Fix bug in memset optimization of ranges::uninitialized_value_construct #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
bug
StephanTLavavej
requested changes
Feb 26, 2021
tests/std/tests/P0896R4_ranges_alg_uninitialized_fill_n/test.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
reviewed
Feb 26, 2021
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
LGTM modulo STL's comments.
StephanTLavavej
approved these changes
Feb 27, 2021
miscco
commented
Feb 28, 2021
Contributor
Author
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Thanks for fixing the remaining issues
CaseyCarter
approved these changes
Mar 1, 2021
Member
|
Thanks for squashing this bug! This will ship in VS 2019 16.10 Preview 2. 🪲 💥 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤦
memset takes count in bytes not number of elements...