_NODISCARD should appear before __declspec #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7fae2aa. Clang was rejecting this with: D:\build\out\inc\xlocale(848,1): error: declaration of anonymous class must be a definition class _CXX20_DEPRECATE_CODECVT_FACETS _CRTIMP2_PURE_IMPORT_UNLESS_CODECVT_ID_SATELLITE ^ D:\build\out\inc\xlocale(849,27): error: expected unqualified-id codecvt<char16_t, char, mbstate_t> : public codecvt_base { ^ D:\build\out\inc\xlocale(1147,1): error: declaration of anonymous class must be a definition class _CXX20_DEPRECATE_CODECVT_FACETS _CRTIMP2_PURE_IMPORT_UNLESS_CODECVT_ID_SATELLITE ^ D:\build\out\inc\xlocale(1148,27): error: expected unqualified-id codecvt<char32_t, char, mbstate_t> : public codecvt_base { ^
CaseyCarter
approved these changes
Mar 1, 2021
AnjuDel
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1702.
_NODISCARDbefore_CRT_SATELLITE_1/_CRT_SATELLITE_2will allow @JonCavesMSFT to activate this new warning. There's no user impact because_CRT_SATELLITE_1/_CRT_SATELLITE_2expand to nothing when importing.move_iterator::operator->()wasn't following the convention of[[deprecated]]occurring before[[nodiscard]]. There's no impact to rearranging these attributes, it just makes the codebase more consistent (and slightly more readable, since it gets the verbose deprecation macro out of the way).