Logic for time_zone sys to local conversion #1732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-winsor
commented
Mar 12, 2021
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/test.cpp
Outdated
Show resolved
Hide resolved
d-winsor
commented
Mar 12, 2021
d-winsor
commented
Mar 12, 2021
StephanTLavavej
requested changes
Mar 13, 2021
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/timezone_data.h
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/timezone_data.h
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/timezone_data.h
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/timezone_data.h
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/timezone_data.h
Outdated
Show resolved
Hide resolved
StephanTLavavej
changed the title
mnatsuhara
approved these changes
Mar 16, 2021
Contributor
mnatsuhara
left a comment
mnatsuhara
left a comment
There was a problem hiding this comment.
All I found were nitpicks! I'm happy to merge this as is and roll these small changes into the follow up PR for zoned_time!
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/test.cpp
Outdated
Show resolved
Hide resolved
mnatsuhara
approved these changes
Mar 16, 2021
StephanTLavavej
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the logic for getting
time_zonetransition information from the ICU and using that to convert betweensys_time<>andlocal_time<>according to the rules of the specifiedtime_zone.Glancing over the tests first may be useful in understanding the different corner cases that need to be considered, particularly around ambiguous and nonexistent
local_timeconversions.