Misc items for tzdb #1765
Merged
Misc items for tzdb #1765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
Mar 22, 2021
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_time_zones/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Mar 23, 2021
Member
|
As the tests passed, I went ahead and merged this - please let me know if I messed anything up during review (particularly using the previously-unused |
Contributor
Author
Looks good to me and that was absolutely a bug :). Just didn't catch it because I would have had to use test hooks to test that pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.