<chrono> [time.parse] #1768
Merged
<chrono> [time.parse] #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Thanks, this is amazing! I've reviewed the product code and (aside from nitpicks/typos that I'll push changes for), I have only 7 open questions - some about proposed stylistic improvements, and a couple about potential integer overflows. I'll resolve all of my comments except those open questions.
I'll review the test code tomorrow.
MattStephanson
commented
Mar 25, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Reviewed test code! Will push simple changes.
StephanTLavavej
approved these changes
Mar 26, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks, this looks great! I pushed a one-line change to remove std:: qualification from numeric_limits.
Member
|
Thanks for taking the time to parse this Standardese into code! 😹 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a minor update to
clock_cast, to recognize thatsys_clockcan be converted directly to/fromutc_clock, even though it doesn't haveto/from_utc.