Cleanup vector a bit #1771
Merged
Cleanup vector a bit #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
commented
Mar 23, 2021
StephanTLavavej
requested changes
Mar 23, 2021
This comment has been minimized.
This comment has been minimized.
barcharcraz
suggested changes
Apr 30, 2021
barcharcraz
approved these changes
Jun 12, 2021
Contributor
barcharcraz
left a comment
barcharcraz
left a comment
There was a problem hiding this comment.
Looks good. Still not thrilled with _Construct_n, but I'm OK if we merge that structure.
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! All I noticed were minor issues so I'll validate and push changes.
StephanTLavavej
approved these changes
Jun 16, 2021
Member
|
Thanks for cleaning up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some cleanups that I found when looking at vector
We have special helper functions
_Uninitialized_meowthat are only used inside vector. However there was an additional indirection whose only purpose was to add_Getal()Cleaned up and generalized the construction of a vector with known size