Skip to content

Conversation

@SuperWig
Copy link
Contributor

@SuperWig SuperWig commented Mar 23, 2021

  • Added singular forms of durations (second, minute, etc.)
  • Added visualisations for the new calendar types.
  • It looks like this
    image

Thoughts and questions

  • The 1st/2nd etc could probably be dropped on day?
  • The _last types might be better without the "Last"s?
  • is_negative should probably be dropped?
  • This is the first time I've messed with natvis' and couldn't find a way to specify a width, is that not possible? Seems a bit hacky the way I did it and should that be used for the calendar types as well to use the ISO date format (YYYY-MM-DD)?

@SuperWig SuperWig requested a review from a team as a code owner March 23, 2021 17:21
@StephanTLavavej StephanTLavavej added the visualizer How the VS debugger displays STL types label Mar 23, 2021
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I'm ok with st/rd/th and Last. They're not localized, but then neither is the rest of this.

SuperWig and others added 2 commits March 24, 2021 07:58
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: statementreply <statementreply@gmail.com>
@CaseyCarter CaseyCarter assigned AnjuDel and unassigned AnjuDel Mar 31, 2021
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review. I noticed one inconsistency in the display string (followed by a simplification). I haven't tested my suggested changes. I'm OK with proceeding to merge without addressing this feedback. However, if these changes are correct and you want to apply them, make sure to update the MSVC and VS PRs too.

Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@AnjuDel AnjuDel merged commit 4ee3f91 into microsoft:main Apr 9, 2021
@StephanTLavavej
Copy link
Member

Thanks @SuperWig for these awesome visualizers and thanks @AnjuDel for merging this to the internal repos! 🎉 👁️ 📆 😸

@SuperWig SuperWig deleted the natvis branch April 10, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

visualizer How the VS debugger displays STL types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants