-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Visualise C++20 chrono additions #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CaseyCarter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, I'm ok with st/rd/th and Last. They're not localized, but then neither is the rest of this.
Co-authored-by: Casey Carter <cartec69@gmail.com> Co-authored-by: statementreply <statementreply@gmail.com>
StephanTLavavej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late review. I noticed one inconsistency in the display string (followed by a simplification). I haven't tested my suggested changes. I'm OK with proceeding to merge without addressing this feedback. However, if these changes are correct and you want to apply them, make sure to update the MSVC and VS PRs too.
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Thoughts and questions
day?_lasttypes might be better without the "Last"s?is_negativeshould probably be dropped?