<optional>: Fix mystery LWG issue citations #1788
Conversation
|
Congratulations on your first contribution 🎉 |
|
@Athira2199 Status update - I've pushed a commit to this PR, resolving the pre-existing issue with paragraph numbers that @CaseyCarter pointed out. (Nothing was wrong with your changes, and you perfectly followed the steps that I explained 😸 - I had simply failed to notice that these paragraph numbers were off by one and also needed fixing.) By default, when you submit a PR, the maintainers of the target repo can push changes to that branch of your fork, to fix issues discovered during code review - we commonly do so when we find small issues that don't need major rework. Our code review process needs 2 approvals for every PR, so I've asked @CaseyCarter to take another look. After he approves, we'll move your PR to the Ready To Merge column in our Code Reviews project, and then we'll merge it shortly afterwards. (Another part of our process is that we simultaneously merge changes on GitHub and the Microsoft-internal repo where MSVC is built; this is semi-manual so we batch up PRs to save work.) |
|
@StephanTLavavej thank you for helping me out and explaining each process in detail. 😃 |
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Looks good - congratulations on your first STL contribution!
|
Thanks for fixing these citations, and congrats again! I'm recording this in the Changelog as shipping in "Dev17" 17.0 Preview 1, but hopefully (after we "backport" commits internally) it will ship earlier in VS 2019 16.10 Preview 3 so you can see your changes in Visual Studio very soon. 😸 🎉 🚀 |
4 participants
Fixes #1770.