<format>: Allow move-only output iterators #1795
Conversation
Had to "move" them, eh? Good one! |
eldakesh-ms
force-pushed
the
format/move-iter
branch
from
7bae485 to
5e63376
Compare
|
Squashed and rebased. Double checked that I didn't undo any |
|
|
||
| iterator out() { | ||
| return _OutputIt; | ||
| return _STD move(_OutputIt); |
There was a problem hiding this comment.
this makes me spooked! in particular because basic_format_context and basic_format_parse_context are to be used in user supplied custom formatters
| template <class _Ty> | ||
| _OutputIt operator()(_Ty _Val) { | ||
| return _Write<_CharT>(_Out, _Val); | ||
| return _Write<_CharT>(_STD move(_Out), _Val); |
There was a problem hiding this comment.
This means _Default_arg_formatter op()s can also be called only once, like the basic_format_context .out() member function.
| basic_format_parse_context<_CharT> _Parse_ctx({}); | ||
| basic_format_context<_OutputIt, _CharT> _Format_ctx(_Out, _Args, _Loc); | ||
| basic_format_context<_OutputIt, _CharT> _Format_ctx(_STD move(_Out), _Args, _Loc); | ||
| _Handle.format(_Parse_ctx, _Format_ctx); |
There was a problem hiding this comment.
This copy may be problematic.
|
There is an outstanding issue with custom formatting. It's not a result of this PR, but running the tests without |
Now we move around the iterator we get instead of copying it. I had to move a few functions from their home in algorithm and xmemory into xutility. I hope I got the comments/guards correct, but please double check those. The testing is done by making sure we don't use-after-move a custom iterator and that all the printing functions are instantiated.
eldakesh-ms
force-pushed
the
format/move-iter
branch
from
1317e95 to
17d3030
Compare
|
Rebased, double check the function moves as those were re-done (xutilty, xmemory, algorithm). |
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
I am not 100% up to date with fmt but the changes look good for me
4 participants
Now we move around the iterator we get instead of copying it. I had to
move a few functions from their home in algorithm and xmemory into
xutility. I hope I got the comments/guards correct, but please double
check those.
The testing is done by making sure we don't use-after-move a custom
iterator and that all the printing functions are instantiated.