Activate vectorized algorithms for ARM64EC #1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Apr 2, 2021
Contributor
There was a problem hiding this comment.
I'd prefer #ifndef MEOW to #if !defined(MEOW), but I don't want to hold this up for such an insignificant change and I think we're already inconsistent.
EDIT: I doubly don't want to bother with such an insignificant change given that the internal PR has been merged.
MahmoudGSaleh
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports Ben Niu's MSVC-PR-314800, activating the STL's vectorized algorithms for ARM64EC, now that the compiler supports the various SSE intrinsics that we need. However, the AVX2 intrinsics are still unavailable, so we need to guard them.