Skip to content

Avoid calling size() in empty() member functions #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 1 commit into from
May 1, 2021
Merged

Avoid calling size() in empty() member functions #1836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stl/inc/vector
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2798,7 +2798,7 @@ public:
}

_NODISCARD _CONSTEXPR20_CONTAINER bool empty() const noexcept {
return size() == 0;
return this->_Mysize == 0;
}

_NODISCARD _CONSTEXPR20_CONTAINER allocator_type get_allocator() const noexcept {
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/xstring
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4016,7 +4016,7 @@ public:
#endif // _HAS_CXX20

_NODISCARD _CONSTEXPR20_CONTAINER bool empty() const noexcept {
return size() == 0;
return _Mypair._Myval2._Mysize == 0;
}

_CONSTEXPR20_CONTAINER size_type copy(
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/xtree
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,7 +1216,7 @@ public:
}

_NODISCARD bool empty() const noexcept {
return size() == 0;
return _Get_scary()->_Mysize == 0;
}

_NODISCARD allocator_type get_allocator() const noexcept {
Expand Down