Visualise source_location
#1837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperWig
commented
Apr 14, 2021
AnjuDel
suggested changes
Apr 15, 2021
AnjuDel
approved these changes
Apr 16, 2021
StephanTLavavej
approved these changes
Apr 28, 2021
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
requested changes
May 7, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
The checks are failing because:
Validation failed: .\stl\debugger\STL.natvis contains LF line endings.
Validation failed: .\stl\debugger\STL.natvis contains 1 lines with trailing whitespace.
StephanTLavavej
requested changes
May 11, 2021
StephanTLavavej
approved these changes
May 12, 2021
Member
|
Approved the internal mirrors MSVC-PR-323231 and VS-PR-323226, thanks @AnjuDel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe the function name could be included in the display string? Thought that could get a be a bit long though so opted for just the line and column number. Also not sure if I did the strings correctly 🤷♂️