Skip to content

update header units test for VSO-1309454 #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 1 commit into from
Apr 16, 2021
Merged

update header units test for VSO-1309454 #1841

StephanTLavavej merged 1 commit into from
Apr 16, 2021

Conversation

@cdacamar
Copy link
Contributor

@cdacamar cdacamar commented Apr 15, 2021

With the completion of MSVC-PR-317846 these workarounds can be tentatively removed (internally tested).

@cdacamar cdacamar requested a review from a team as a code owner April 15, 2021 22:47
@CaseyCarter CaseyCarter changed the title update header units test for ADO1309454 update header units test for VSO-1309454 Apr 15, 2021
@CaseyCarter CaseyCarter added the test Related to test code label Apr 15, 2021
@StephanTLavavej StephanTLavavej merged commit a108657 into microsoft:main Apr 16, 2021
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Apr 16, 2021

Thanks for fixing this compiler bug affecting deduction guides with header units! 🪲 😸 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Related to test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdacamar @StephanTLavavej @CaseyCarter