filesys.cpp: Remove C casts #1843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
Apr 20, 2021
CaseyCarter
approved these changes
Apr 21, 2021
Contributor
|
Other reviewers are likely to be confused now that the description no longer quite agrees with the changes; I suggest you update it. |
StephanTLavavej
changed the title
StephanTLavavej
approved these changes
Apr 28, 2021
Member
|
Thanks for removing these C casts and completing this step of codebase modernization! 😺 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to issue #184
This PR fixes the remaining C cast to C++
Changes
HANDLEis an alias for void*, so this cast was extraneous. Thus Removed theHANDLEcast