chronat: Allow day from month_day_last conditionally #1845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to matt and stat on discord for mentioning these edge cases. I originally thought that you can't get a day from `month_day_last`, but it clearly makes sense, for most months. I changed some machinery around so that we can always intercept a specifier, which means that we need to do manual checking in the writer for localization. This PR is more to illustrate how a specifier may be intercepted, and that testing need only be done for specific types.
mnatsuhara
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @MattStephanson and @statementreply on discord for mentioning these edge cases.
I originally thought that you can't get a day from
month_day_last, butit clearly makes sense, for most months. I changed some machinery around
so that we can always intercept a specifier, which means that we need to
do manual checking in the writer for localization.
This PR is more to illustrate how a specifier may be intercepted, and
that testing need only be done for specific types.